Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report on CSS v4.0.1 #6

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Report on CSS v4.0.1 #6

merged 2 commits into from
Jun 27, 2022

Conversation

michielbdejong
Copy link
Collaborator

CSS is currently passing all CRUD and WAC tests, except:

  • because the SOLID and CRUD tests rely on the live solidcommunity.net server which has a bug, you need to run CSS with:
    • git checkout v4.0.1
    • npm ci
    • comment out line 16 of node_modules/@solid/access-token-verifier/dist/algorithm/verifySolidAccessTokenIssuer.js
    • npm start
  • the concurrency tests fail (these test an optional feature, not required by Solid v0.9), so run the CRUD tests with SKIP_CONC=1
  • some of the WAC tests for Create fail, see Investigate 4 CSS v4.0.1 failures in create.test.ts web-access-control-tests#51

I'm opening this PR to discuss these new test results before publishing them on solidservers.org
Will wait at least 14 days, so this PR will be merged on or after 27 June.

@michielbdejong michielbdejong merged commit bde982c into main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant