Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a file should require write permission on the container #729

Closed
RubenVerborgh opened this issue Aug 2, 2018 · 7 comments
Closed
Labels
enhancement inrupt-sprint Issues that Inrupt plans to work on in near future semver-major Involves breaking API changes
Milestone

Comments

@RubenVerborgh
Copy link
Contributor

Possibly needs to be addressed in solid-permissions.

@RubenVerborgh RubenVerborgh added this to the 5.0.0 milestone Aug 2, 2018
@dmitrizagidulin
Copy link
Contributor

Why on the container? (and not the file itself, which is how it currently is.)

@dmitrizagidulin
Copy link
Contributor

That doesn't quite make sense. If I upload the file somewhere, I should be able to delete it. (Without necessarily being able to delete or edit the container where I uploaded it..)

@dmitrizagidulin
Copy link
Contributor

(Also, we should probably have this discussion on https://github.com/solid/web-access-control-spec, no?)

@RubenVerborgh
Copy link
Contributor Author

This was just brought up in a meeting today, I'm mainly marking it for follow-up. The idea is that write access should enable people to empty a file, but not delete it. As on Linux systems, deleting should require write permissions on the folder, as you're changing the listing of that folder.

@dmitrizagidulin
Copy link
Contributor

Ahh, I didn't realize that was the Linux behavior..

@RubenVerborgh
Copy link
Contributor Author

Handling this in solid-contrib/solid-permissions#28.

@kjetilk kjetilk added triage Issues that need team review and removed triage Issues that need team review labels Nov 2, 2018
@kjetilk kjetilk added the inrupt-sprint Issues that Inrupt plans to work on in near future label Nov 22, 2018
@kjetilk kjetilk reopened this Nov 22, 2018
@kjetilk kjetilk added this to To do in NSS-5.0.0 via automation Nov 22, 2018
@rubensworks
Copy link
Contributor

Done in #1014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement inrupt-sprint Issues that Inrupt plans to work on in near future semver-major Involves breaking API changes
Projects
None yet
Development

No branches or pull requests

4 participants