Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ./data the default root folder #510

Merged
merged 3 commits into from
Jun 22, 2017
Merged

Conversation

dmitrizagidulin
Copy link
Contributor

No description provided.

@dmitrizagidulin
Copy link
Contributor Author

cc @RubenVerborgh for review

@RubenVerborgh RubenVerborgh self-requested a review June 22, 2017 20:14
Copy link
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@@ -10,9 +10,9 @@ module.exports = [
// },
{
name: 'root',
help: "Root folder to serve (defaut: './')",
help: "Root folder to serve (defaut: './data')",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fix the defaut typo here as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :) Will do

@dmitrizagidulin dmitrizagidulin merged commit 1d8e88a into dz_oidc Jun 22, 2017
@dmitrizagidulin dmitrizagidulin deleted the dz_default_root_folder branch June 22, 2017 21:11
dmitrizagidulin added a commit that referenced this pull request Jun 30, 2017
* Make ./data the default root folder

* Add ./data to .gitignore

* Fix typo in help text
@RubenVerborgh RubenVerborgh added this to the 4.0.0 milestone Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants