Further clarify requirements for PUT-to-create and PATCH-to-create #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the text to match what we decided in solid#105 (comment). At the time we decided not to update the spec text, but now that the spec text is more detailed, the current statement is not correctly conveying that access to both the containing folder and the non-existing resource URL is required. See the confusion that was created by this in solid-contrib/web-access-control-tests#56 which was an (I think incorrect) reaction to solid#122.
TallTed
reviewed
Dec 6, 2023
TallTed
reviewed
Dec 6, 2023
csarven
requested changes
Dec 13, 2023
There was a problem hiding this comment.
@michielbdejong , the requested clarification is good / in the right direction, thanks!
I've requested changes building on suggestions made by @michielbdejong @TallTed .
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
csarven
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACL permission requirements are hard to follow even if you spell them out completely, and in this spec text we try to speak in generic terms about them, and only mention the aspects that are worth noting, and that makes it even harder.
I might be getting this wrong because it's all so complex, but here's what I think now after reading the recent comments:
It seems #122 created some confusion.
This updates the text to match what we decided in response to a similar but unrelated confusion.
At the time we decided not to update the spec text, but now that the spec text is more detailed, the current statement is not correctly conveying that access to both the containing folder and the non-existing resource URL is required.