You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The <NavLink> component from solid-app-router is marking the Docs Header as the current page (aria-current="page") in all pages, not only docs.solidjs.com (expected behavior). Here's the current behavior and what would be expected or not:
docs.solidjs.com -> Docs Header is the current page ✅ docs.solidjs.com/tutorials/getting-started-with-solid/welcome -> Docs Header is the current page ❌ Welcome link is the current page ✅
Fortunately, we can fix this by adding the end={true} prop to NavLink. I have a PR ready with the fix.
The text was updated successfully, but these errors were encountered:
The
<NavLink>
component fromsolid-app-router
is marking the Docs Header as the current page (aria-current="page") in all pages, not onlydocs.solidjs.com
(expected behavior). Here's the current behavior and what would be expected or not:docs.solidjs.com
-> Docs Header is the current page ✅docs.solidjs.com/tutorials/getting-started-with-solid/welcome
-> Docs Header is the current page ❌ Welcome link is the current page ✅Fortunately, we can fix this by adding the
end={true}
prop to NavLink. I have a PR ready with the fix.The text was updated successfully, but these errors were encountered: