Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Navbar Header incorrectly being marked as current page #85

Closed
yanthomasdev opened this issue Jun 28, 2022 · 0 comments · Fixed by #86
Closed

Docs Navbar Header incorrectly being marked as current page #85

yanthomasdev opened this issue Jun 28, 2022 · 0 comments · Fixed by #86

Comments

@yanthomasdev
Copy link
Contributor

The <NavLink> component from solid-app-router is marking the Docs Header as the current page (aria-current="page") in all pages, not only docs.solidjs.com (expected behavior). Here's the current behavior and what would be expected or not:

docs.solidjs.com -> Docs Header is the current page ✅
docs.solidjs.com/tutorials/getting-started-with-solid/welcome -> Docs Header is the current page ❌ Welcome link is the current page ✅

Fortunately, we can fix this by adding the end={true} prop to NavLink. I have a PR ready with the fix.

madaxen86 pushed a commit to madaxen86/solid-docs-next that referenced this issue Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant