Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docs Header being marked as current page in all pages #86

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix Docs Header being marked as current page in all pages #86

merged 1 commit into from
Jun 30, 2022

Conversation

yanthomasdev
Copy link
Contributor

@yanthomasdev yanthomasdev commented Jun 28, 2022

The issue has a detailed explanation of the issue, this PR simply adds the end={true} prop to the NavLink component.

@netlify
Copy link

netlify bot commented Jun 28, 2022

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 12aa93f
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/62bb940b9fed430008816f2f
😎 Deploy Preview https://deploy-preview-86--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jutanium Jutanium merged commit 80e7785 into solidjs:main Jun 30, 2022
madaxen86 pushed a commit to madaxen86/solid-docs-next that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Navbar Header incorrectly being marked as current page
3 participants