fix unintended early return in cache during server render

solidjs · Feb 20, 2024 · 533b7a0 · 533b7a0
1 parent 959c353
commit 533b7a0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/shaggy-cooks-teach.md b/.changeset/shaggy-cooks-teach.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/router": patch
+---
+
+fix unintended early return in cache during server render
diff --git a/src/data/cache.ts b/src/data/cache.ts
@@ -139,8 +139,7 @@ export function cache<T extends (...args: any) => any>(fn: T, name: string): Cac
     }
     if (isServer) {
       const e = getRequestEvent();
-      e && e.router!.dataOnly && (e.router!.data![key] = res);
-      return res;
+      if (e && e.router!.dataOnly) return (e.router!.data![key] = res);
     }
     if (intent !== "preload") {
       res =