Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode on SolidJS website #129

Closed
trivikr opened this issue Aug 13, 2021 · 4 comments · Fixed by #221
Closed

Add dark mode on SolidJS website #129

trivikr opened this issue Aug 13, 2021 · 4 comments · Fixed by #221

Comments

@trivikr
Copy link
Contributor

trivikr commented Aug 13, 2021

Is your feature request related to a problem? Please describe.

The website https://www.solidjs.com/ does not have a dark mode.

Describe the solution you'd like

  • Add dark mode for the website.
  • Automatically load a dark or light theme based on system preferences.
  • Allow the user to manually override their preference using a toggle in the title/navigation bar, and maintain preferred theme between page reloads.

Describe alternatives you've considered

  • Reduce brightness of the screen while reading SolidJS website.
  • Use a browser extension to enforce dark mode on the website.
  • Revisit the website in the mornings when system has light mode enabled.
@trivikr
Copy link
Contributor Author

trivikr commented Aug 18, 2021

Tailwind CSS includes a dark variant that allows styling site differently when dark mode is enabled.

@trivikr
Copy link
Contributor Author

trivikr commented Aug 18, 2021

cc @amoutonbrady for comments, as they have been active in this repo.

@trivikr
Copy link
Contributor Author

trivikr commented Aug 18, 2021

Solid playground already has a dark mode.

Screen recording
solid-playground-dark-mode.mov

It was added in solidjs/solid-playground#47
cc @aquaductape who added dark mode to the Playground for comments.

@davedbase
Copy link
Member

Yup I'd love to add this to the Solid website for consistency with Playground. We'd happily accept a PR to make it functional. I'd then likely be somewhat picky about colours and proper use of branded assets but the first step is to get the button in place and working with the Tailwind dark variant.

This was referenced Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants