-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Nested Routing and Manifests #15
Comments
To improve the status quo, this line https://github.com/solidjs/solid-start/blob/main/packages/start/components/Outlet.tsx#L22 could be extended to
That generates this route structure:
Compared to the previous route structure that doesn't work at all:
|
* Not optimal but makes nested routes possible
I think the route structure should be ideally: <Routes>
<Route path="/account/registration" element=..>
<Route path="/" element=.. />
<Route path="/otherpage" element=.. />
</Route>
</Routes> There is no need for an intermediate slash path.. technically in this example only the top route is the shared layout. |
Oh yes, you're right. The patch produces exactly that route |
Could you take a look at it and merge it to main/release it? |
Solid App Router supports nested routing. They do so by naming a file the same name as the folder. In so it acts as the parent. I haven't added that yet.
In addition we need to make sure that manifest lookup for preload works as well.
The text was updated successfully, but these errors were encountered: