Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Vite field in the app config has wrong types #1513

Closed
2 tasks done
drumm2k opened this issue May 25, 2024 · 1 comment
Closed
2 tasks done

[Bug?]: Vite field in the app config has wrong types #1513

drumm2k opened this issue May 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@drumm2k
Copy link

drumm2k commented May 25, 2024

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

vite field in config has any type

The reason is wrong import path in node_modules/@solidjs/start/config/index.d.ts

Cannot find module 'vinxi/dist/types/lib/vite-dev' or its corresponding type declarations.

import type { CustomizableConfig } from "vinxi/dist/types/lib/vite-dev";

type ViteCustomizableConfig = CustomizableConfig & {
  server?: InlineConfig["server"];
}

Tried to fix this issue by myself, but vinxi doesn't export CustomizableConfig in any obvious way

Expected behavior 🤔

Vite field has right typings in the config

Steps to reproduce 🕹

Steps:

  1. Add vite field to defineConfig in app.config.ts
  2. Check its type

Context 🔦

Would love to have good DX when vite options in config are typed

Your environment 🌎

Package manager: pnpm (9.1.2)
Editor: vscode (latest stable)

Installed packages:
"@solidjs/start": "^1.0.0",
"vinxi": "^0.3.11"
@drumm2k drumm2k added the bug Something isn't working label May 25, 2024
@drumm2k
Copy link
Author

drumm2k commented May 26, 2024

found duplicate, so closing this issue

@drumm2k drumm2k closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant