fix #1917 - hydration error during streaming

solidjs · Oct 18, 2023 · 1f0226e · 1f0226e
1 parent 654e2c0
commit 1f0226e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/long-swans-bow.md b/.changeset/long-swans-bow.md
@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+fix #1917 for real this time
diff --git a/packages/solid/src/render/Suspense.ts b/packages/solid/src/render/Suspense.ts
@@ -144,7 +144,7 @@ export function Suspense(props: { fallback?: JSX.Element; children: JSX.Element
   if (sharedConfig.context && sharedConfig.load) {
     const key = sharedConfig.context.id + sharedConfig.context.count;
     let ref = sharedConfig.load(key);
-    if (ref && (typeof ref !== "object" || !("value" in ref))) p = ref;
+    if (ref && (typeof ref !== "object" || ref.status !== "success")) p = ref;
     if (p && p !== "$$f") {
       const [s, set] = createSignal(undefined, { equals: false });
       flicker = s;