Skip to content

Commit

Permalink
fix #1493 export DynamicProps (#1504)
Browse files Browse the repository at this point in the history
* fix #1493 export DynamicProps

* add changeset

---------

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>
  • Loading branch information
codyebberson and ryansolid committed Jan 29, 2023
1 parent b7e51b7 commit dd879da
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/eight-experts-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"solid-js": patch
---

fix #1493 export DynamicProps
4 changes: 3 additions & 1 deletion packages/solid/web/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ export function Portal<T extends boolean = false, S extends boolean = false>(pro
return marker;
}

type DynamicProps<T extends ValidComponent, P = ComponentProps<T>> = { [K in keyof P]: P[K] } & {
export type DynamicProps<T extends ValidComponent, P = ComponentProps<T>> = {
[K in keyof P]: P[K];
} & {
component: T | undefined;
};
/**
Expand Down

0 comments on commit dd879da

Please sign in to comment.