Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximum call stack size exceeded in Suspense error handling on the server #1648

Closed
thetarnav opened this issue Mar 25, 2023 · 0 comments · Fixed by #1649
Closed

Maximum call stack size exceeded in Suspense error handling on the server #1648

thetarnav opened this issue Mar 25, 2023 · 0 comments · Fixed by #1649
Labels
bug Something isn't working

Comments

@thetarnav
Copy link
Contributor

thetarnav commented Mar 25, 2023 •
edited
Loading

Describe the bug

If an accessed resource throws an error during SSR, Suspense will go into an infinite loop trying to handle it.
This issue only exists in versions >=1.6.13 so most likely this is a regression caused by this commit: 60f8624

I think I know where the problem is, so I'll try to make a PR

image

Your Example Website or App

https://stackblitz.com/edit/server-suspense-infinite-loop?file=index.ts

Steps to Reproduce the Bug or Issue

  1. pnpm i to install deps
  2. pnpm dev to run the server script
  3. look at the error message

Expected behavior

The error should be able to be handled by an error boundary
@thetarnav thetarnav mentioned this issue Mar 25, 2023
Merged
thetarnav added a commit to solidjs-community/solid-primitives that referenced this issue Mar 25, 2023
@thetarnav
Downgrade to solid-js@1.6.12
89808b8 
Until this is resolved:
solidjs/solid#1648
@ryansolid ryansolid added the bug Something isn't working label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix infinite loop in Suspense error handling on the server thetarnav/solid
2 participants
@ryansolid @thetarnav