Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Dynamic {...rest} /> spreads not reactive #322

Closed
russelgal opened this issue Jan 30, 2021 · 1 comment
Closed

<Dynamic {...rest} /> spreads not reactive #322

russelgal opened this issue Jan 30, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@russelgal
Copy link

russelgal commented Jan 30, 2021

https://playground.solidjs.com/?hash=-621971754

test button should update img src but no

@ryansolid
Copy link
Member

Thanks I see the problem.. state isn't creating the right property descriptors they read from the untracked target instead of the proxy. Thanks for reporting.

@ryansolid ryansolid added the bug Something isn't working label Jan 31, 2021
ryansolid added a commit that referenced this issue Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants