Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does it return the value if the prop name is "symbol"? #6

Closed
trusktr opened this issue Oct 8, 2018 · 2 comments
Closed

Why does it return the value if the prop name is "symbol"? #6

trusktr opened this issue Oct 8, 2018 · 2 comments
Labels
question Further information is requested

Comments

@trusktr
Copy link
Contributor

trusktr commented Oct 8, 2018

https://github.com/ryansolid/solid/blob/de578778fbc6333981c0a67c366314ec3c4ce667/src/State.js#L84

Just curious what that does.

@trusktr trusktr changed the title Why return the value if the prop name is "symbol" Why does it return the value if the prop name is "symbol"? Oct 8, 2018
@ryansolid
Copy link
Member

Basically these are things that don't get mapped or tracked. An object might have a iterator symbol etc and we just pass it back unmodified. I haven't hit a scenario where it made sense to map/track a symbol so it's an early exit. If you can think of any I'd be interested.

@ryansolid ryansolid added the question Further information is requested label Oct 27, 2018
@ryansolid
Copy link
Member

I realized this was too specific of an optimization and removed from 0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants