fix(types): add missing ref prop to Portal #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2428538152
💛 - Coveralls |
- Adds the missing `ref` prop to `<Portal>`. - If `isSVG`, the element in `ref` is `SVGGElement`, otherwise it is `HTMLDivElement`. - If `useShadow`, the element in `ref` has a non-null `shadowRoot` property. - `ref` is unused when mounting to `document.head`, however there is no way to detect this as `HTMLHeadElement` is typed identically to `HTMLElement`. See https://tsplay.dev/mb0P2w.
otonashixav
force-pushed
the
fix-missing-portal-ref-type
branch
from
a9afc23
to
a3df9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
refprop to<Portal>.isSVG, the element inrefisSVGGElement, otherwise it isHTMLDivElement.useShadow, the element inrefhas a non-nullshadowRootproperty.refis unused when mounting todocument.head, however there is no way to detect this asHTMLHeadElementis typed identically toHTMLElement.How did you test this change?
See https://tsplay.dev/mb0P2w.