add _$afterCreateRoot
hook to handle new roots in dev
#1067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solid's internal reactivity graph has this problem where roots created with
createRoot
don't have to be added to its detachedOwner object — it's enough that they are able to get to the context walking upwards.But not for devtools, all the
createRoot
calls are effectively invisible for a debugger that wants to walk downwards to analyze the tree. And roots are very common — components such as<For>
,<Index>
and<Suspense>
; primitives that want to control disposal likecreateLazyMemo
; and evenrender
function that is creating the main branch of the reactive tree.Having a special hook that would fire with every newly created root would let us handle all of those cases.
Then it could be used easily for tracking:
Related discussion: #860
And devtools issue: thetarnav/solid-devtools#15
How did you test this change?
Added a new test case to
dev.spec.ts