Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Assign components props to its owner node #1204

Merged
merged 2 commits into from
Sep 4, 2022

Conversation

thetarnav
Copy link
Contributor

@thetarnav thetarnav commented Sep 3, 2022

Adds DevComponent interface for the components owner node.

export interface DevComponent<T> extends Memo<JSX.Element> {
  props: T;
  componentName: string;
}

Assigns props object to the component owner node, so that the debugger can access them.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2983997548

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 89.066%

Totals Coverage Status
Change from base Build 2977811684: 0.08%
Covered Lines: 1262
Relevant Lines: 1346

💛 - Coveralls

@thetarnav thetarnav changed the title DEV: Assign component's props to it's owner node DEV: Assign components props to its owner node Sep 3, 2022
@ryansolid ryansolid merged commit 6a522af into solidjs:main Sep 4, 2022
@thetarnav thetarnav deleted the owner-props branch September 4, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants