Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export isDev const from solid-js/web #1577

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Conversation

thetarnav
Copy link
Contributor

Export isDev const from solid-js/web to make checking development/production envs clearer than using the DEV object with internal methods.

Since the "_SOLID_DEV_" string was replaced with false only in production entries, I've enabled replacing in dev entries as well.
Otherwise, it would have to be declared this way:

export const isDev: boolean = !!"_SOLID_DEV_";

Which is tree shakeable too

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

🦋 Changeset detected

Latest commit: 8a83011

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4256293149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 88.253%

Files with Coverage Reduction New Missed Lines %
packages/solid/web/src/index.ts 2 82.19%
Totals Coverage Status
Change from base Build 4248345040: 0.004%
Covered Lines: 1301
Relevant Lines: 1398

💛 - Coveralls

@ryansolid ryansolid merged commit 61d1fe2 into solidjs:main Feb 24, 2023
@thetarnav thetarnav deleted the is-dev branch February 24, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants