set pnpm version #1762
set pnpm version #1762
Conversation
🦋 Changeset detectedLatest commit: 2db964d The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| with: | ||
| version: 8 |
There was a problem hiding this comment.
| 1. `pnpm install` (install all dependencies) | ||
| 2. `pnpm run build` | ||
| 1. `corepack enable` (use the correct version of PNPM, https://nodejs.org/api/corepack.html#enabling-the-feature) | ||
| 2. `pnpm install` (install all dependencies) | ||
| 3. `pnpm build` |
There was a problem hiding this comment.
Yes, corepack is experimental, but it's the best solution I know of to juggle PNPM versions.
| "engines": { | ||
| "pnpm": ">=8.6.1" | ||
| }, |
There was a problem hiding this comment.
| "engines": { | ||
| "pnpm": ">=8.6.1" | ||
| }, | ||
| "packageManager": "pnpm@8.6.1" |
There was a problem hiding this comment.
https://nodejs.org/docs/latest-v18.x/api/all.html#all_packages_packagemanager
Until the above docs or StackOverflow comes to a clear answer/recommendation, I lean conservative and don't think we should specify a PNPM version range for packageManager, which AFAIK only used for specifying corepack's PNPM version.
|
Thank you |
Pull Request Test Coverage Report for Build 5383797133Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Summary
Manually specify PNPM version so new contributors' PNPM version and lockfile don't get out of sync.