Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge props #1764

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix merge props #1764

merged 3 commits into from
Jun 26, 2023

Conversation

juanrgm
Copy link
Contributor

@juanrgm juanrgm commented Jun 6, 2023

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 0b37898

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jun 6, 2023

Pull Request Test Coverage Report for Build 5191552748

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.24%

Totals Coverage Status
Change from base Build 5177320944: -0.02%
Covered Lines: 4126
Relevant Lines: 4307

💛 - Coveralls

@juanrgm
Copy link
Contributor Author

juanrgm commented Jun 16, 2023

Could it be merged?

@AlexErrant
Copy link
Contributor

Ryan's off on the conference circuit so merging will likely be delayed til he gets home.

@ryansolid
Copy link
Member

Thank you

@ryansolid ryansolid merged commit 8ba0e80 into solidjs:main Jun 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants