Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate errors to parents when throwing errors in nested catchError #1774

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

Exelord
Copy link
Contributor

@Exelord Exelord commented Jun 10, 2023

Summary

While Im not sure yet if this is really the expected behaviour (at lest that's what doc says), it was quite easy to make catchError errors bubbling through parents.

Fixes: #1773

How did you test this change?

pnpm test

@changeset-bot
Copy link

changeset-bot bot commented Jun 10, 2023

🦋 Changeset detected

Latest commit: 6591778

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit 0100bd1 into solidjs:main Jun 26, 2023
1 check passed
@ryansolid
Copy link
Member

Thank you

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5383956197

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 10 of 17 (58.82%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 94.018%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/reactive/signal.ts 10 17 58.82%
Files with Coverage Reduction New Missed Lines %
packages/solid/src/index.ts 1 97.8%
packages/solid/web/src/server-mock.ts 5 94.57%
packages/solid/src/render/component.ts 8 91.04%
Totals Coverage Status
Change from base Build 5177320944: -0.2%
Covered Lines: 4124
Relevant Lines: 4317

💛 - Coveralls

@Exelord Exelord deleted the fix-catch-error-propagation branch February 11, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catchError is not propagating error to parent
3 participants