Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix createMutable getters do not work if they're on the prototype #1746 #2027

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

takeramagan
Copy link
Contributor

issue related: #1746

Copy link

changeset-bot bot commented Jan 12, 2024

⚠️ No Changeset found

Latest commit: ee22b8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@takeramagan
Copy link
Contributor Author

@ryansolid Updated test, please review. if you remove the changes, then the test will fail

@ryansolid ryansolid merged commit 9daf01f into solidjs:main Jan 22, 2024
1 check passed
@ryansolid
Copy link
Member

Thank you. This is probably one of those features it would have taken me forever to get around to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants