Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #429

Merged
merged 1 commit into from
Apr 29, 2021
Merged

fix some typos #429

merged 1 commit into from
Apr 29, 2021

Conversation

milomg
Copy link
Member

@milomg milomg commented Apr 29, 2021

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 796730962

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.858%
Totals Coverage Status
Change from base Build 794913070: 0.0%
Covered Lines: 1029
Relevant Lines: 1088
💛 - Coveralls

@ryansolid
Copy link
Member

Not to be annoying but can you do this sort of PR against next branch. I need to keep merging stuff in from main and it would be better than DOC type PRs go against that.

@milomg milomg changed the base branch from main to next April 29, 2021 16:49
@milomg
Copy link
Member Author

milomg commented Apr 29, 2021

Did that work?

@ryansolid ryansolid merged commit dfce9e9 into solidjs:next Apr 29, 2021
@ryansolid
Copy link
Member

Looks like it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milomg @coveralls @ryansolid