Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent hashValue from throwing when stringifying bigints #561

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

otonashixav
Copy link
Contributor

hashValue uses JSON.stringify which throws when it encounters a bigint. This commit fixes that by checking for bigints and converting them to strings and appending n when stringifying.

hashValue uses `JSON.stringify` which throws when it encounters a bigint. This commit fixes that by checking for bigints and converting them to strings and appending `n` when stringifying.
@otonashixav otonashixav changed the title fix: hashValue from throwing when stringifying bigints Prevent hashValue from throwing when stringifying bigints Jul 14, 2021
@otonashixav otonashixav changed the title Prevent hashValue from throwing when stringifying bigints fix: Prevent hashValue from throwing when stringifying bigints Jul 14, 2021
@coveralls
Copy link

coveralls commented Jul 14, 2021

Pull Request Test Coverage Report for Build 1031446667

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 90.225%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/solid/src/reactive/signal.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 1023214926: -0.08%
Covered Lines: 1061
Relevant Lines: 1126

💛 - Coveralls

@ryansolid ryansolid merged commit fbd9605 into solidjs:main Jul 14, 2021
@ryansolid
Copy link
Member

Thanks

@otonashixav otonashixav deleted the fix-hash-value-bigint branch July 15, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants