Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2 fixes #6

Merged
merged 4 commits into from
Jan 20, 2017
Merged

0.2 fixes #6

merged 4 commits into from
Jan 20, 2017

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 19, 2017

The same fixes from #5 but for the v0.2 branch

Thomas von Deyen added 4 commits January 19, 2017 18:54
Spree 3 introduced a new helper for delete buttons without text. Therefore they renamed the link_to_remove_fields helper.

Also adds a feature spec for basic volume price management tasks.
The volume price models controller introduced a method in da2b3a6

This method is neither tested, nor used anywhere. The volume price model model doesn’t even have a children relation.
The generators, the engine.rb class and the version file has no code relevant to coverage.
@tvdeyen tvdeyen requested a review from mamhoff January 19, 2017 18:23
@tvdeyen tvdeyen changed the base branch from master to v0.2 January 19, 2017 18:28
@tvdeyen tvdeyen mentioned this pull request Jan 19, 2017
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvdeyen tvdeyen merged commit 01865cf into v0.2 Jan 20, 2017
@tvdeyen tvdeyen deleted the 0.2-fixes branch January 20, 2017 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants