Role fix #9
Merged
Role fix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/spree-contrib/spree_volume_pricing/blob/da2b3a6dee84be7fd00a1684021095a5668414a2/app/models/spree/variant_decorator.rb#L25-L28 was the behavior that was unaccounted for during the upgrade |
Volume prices by default are not associated with any role. Users however in old systems are associated with the "User" role by default. This means that when a user is logged in, they will never get prices that don't require a role. Instead, if a user is logged in, they should see prices that are non role specific, and prices that are.
Because you can get prices from roles and non roles (if you use one system, you probably don't want to use the other), after ordering by position order by amount. That way the user gets the cheapest price for their role/non-role combination
mamhoff
approved these changes
Apr 6, 2017
|
Thank you! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume prices by default are not associated with any role. Users however
in old systems are associated with the "User" role by default.
This means that when a user is logged in, they will never get prices
that don't require a role.
Instead, if a user is logged in, they should see prices that are non
role specific, and prices that are.
Also bumps the gem version. Will need a push to rubygems