Add limitation to reimbursement hook #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushswain
approved these changes
Jul 10, 2023
piyushswain
approved these changes
Jul 10, 2023
DanielePalombo
requested changes
Jul 10, 2023
Comment on lines
33
to
48
|
|
||
| context 'when target solidus version is lower than the cop minimum solidus version' do | ||
| let(:config) { RuboCop::Config.new('AllCops' => { 'TargetSolidusVersion' => '2.10' }) } | ||
|
|
||
| it 'avoid to register an offense when using `#reimbursement_success_hooks.each`' do | ||
| expect_no_offenses(<<~RUBY) | ||
| reimbursement_success_hooks.each | ||
| RUBY | ||
| end | ||
|
|
||
| it 'avoid to register an offense when using `#reimbursement_failed_hooks.each`' do | ||
| expect_no_offenses(<<~RUBY) | ||
| reimbursement_failed_hooks.each | ||
| RUBY | ||
| end | ||
| end |
There was a problem hiding this comment.
It looks to me that these tests are not related with the change.
I would suggest to remove them, minimum_solidus_version 2.11 it's just a configuration and the behavior should be tested on add_offense method.
There was a problem hiding this comment.
Tests removed after merging #42
Add minimum Solidus version limitation to the reimbursement hook because the deprecation is introduced starting from Solidus 2.11.
MassimilianoLattanzio
force-pushed
the
ml/limit-reimbursement-hook-cop
branch
from
dbda3d0
to
a4c2cee
Compare
|
Closed in favor of #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimum Solidus version limitation to the reimbursement hook because the deprecation is introduced starting from Solidus 2.11.
Closes #27.