Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidus target version fixes #42

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Solidus target version fixes #42

merged 4 commits into from
Jul 11, 2023

Conversation

MassimilianoLattanzio
Copy link
Collaborator

After merging #39, we decided to apply some fixes to the new module. Mainly, the two main changes are:

  • pass all attributes to the add_offense method
  • make add_offense the only public method and rewrite all specs after this update

@MassimilianoLattanzio MassimilianoLattanzio self-assigned this Jul 10, 2023
DanielePalombo
DanielePalombo approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@DanielePalombo DanielePalombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you for this refactor

piyushswain
piyushswain approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@piyushswain piyushswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MassimilianoLattanzio MassimilianoLattanzio merged commit fdf6bc1 into master Jul 11, 2023
1 check passed
@MassimilianoLattanzio MassimilianoLattanzio deleted the ml/solidus-target-version-fixes branch July 11, 2023 08:44
@MassimilianoLattanzio MassimilianoLattanzio mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielePalombo DanielePalombo DanielePalombo approved these changes

@piyushswain piyushswain piyushswain approved these changes

Assignees

@MassimilianoLattanzio MassimilianoLattanzio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MassimilianoLattanzio @DanielePalombo @piyushswain