Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename open/close_adjustments routes? #326

Closed
jordan-brough opened this issue Aug 25, 2015 · 1 comment
Closed

Rename open/close_adjustments routes? #326

jordan-brough opened this issue Aug 25, 2015 · 1 comment

Comments

@jordan-brough
Copy link
Contributor

See discussion here: #321 (comment)

As of #279 we're deprecating "open" and "close" on Adjustment in general. Shall we also change the /open_adjustments and /close_adjustments routes to /finalize_adjustments and /unfinalize_adjustments?

@cbrunsdon
Copy link
Contributor

I'm usually a fan of nesting resources where things make sense.

Rather then close_adjustments and unfinalize_adjustments I'd personally prefer /orders/:id/adjustments/finalize and /orders/:id/adjustments/unfinalize.

Also are we tied to finalize/unfinalize? I've decided I'm partial to "settle"/"unsettle", but mostly because I don't like the concept of "finalizing" something that is finalized.

cbrunsdon added a commit that referenced this issue Dec 11, 2015
…routes

Fix #326: Rename routes due to deprecation of open/close on order adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants