Fixes for adjustment finalizing/unfinalizing#321
Merged
Conversation
The `where(state: ...)` clauses were broken here. The specs didn't catch this because they were stubbed out. Also, there was a `!` missing on the `Adjustment#open!` method.
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Should we also deprecate the old scope and add finalized and not_finalized scopes instead? I find it slightly confusing that this is the one place where we still use closed and open.
Contributor
Author
There was a problem hiding this comment.
That seems like a good idea to me. I'll add that.
Contributor
|
👍 |
Contributor
Author
|
@jhawthorn @magnusvk I added deprecation of open/closed scopes. Still look good? |
Contributor
|
Still good 👍 |
Contributor
Author
|
@magnusvk @jhawthorn I suppose we could update and deprecate the routes as well. I'm OK either way there, do you guys have any preferences? |
Contributor
|
Looks good. 👍 Let's get this merged first; then maybe we can have a discussion about deprecating and renaming the routes on a separate issue? |
jhawthorn
added a commit
that referenced
this pull request
Aug 25, 2015
Fixes for adjustment finalizing/unfinalizing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
where(state: ...)clauses were broken here. The specs didn'tcatch this because they were stubbed out.
Also, there was a
!missing on theAdjustment#open!method.