Remove update_adjustments AR callbacks #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing behaviour was that line_items and shipments had their adjustments recalculated after save. This would update the item's adjustments and the item's _total columns. However this doesn't update the order's _total columns until order.update! is run. Since order.update! will update these values anyways, and since the order is in an inconsistent state until order.update! is run, we should remove these callbacks.
jhawthorn
force-pushed
the
remove_adjustment_callbacks
branch
from
d4a4dca
to
fd3dff1
Compare
|
This is excellent. 💯 |
|
👍 Thank you! |
|
I'm a serious 👍 on this as well |
This was referenced Aug 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing behaviour was that line_items and shipments had their adjustments recalculated after save. This would update the item's adjustments and the item's
*_totalcolumns. However this doesn't update the order's*_totalcolumns untilorder.update!is run.Since order.update! will update these values anyways, and since the order is in an inconsistent state until
order.update!is run, we should remove these callbacks.Related to #1252