Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix taxons page with new Spree.ajax calls (and cleanup) #157

Merged
merged 12 commits into from
Jul 27, 2015
Merged

Fix taxons page with new Spree.ajax calls (and cleanup) #157

merged 12 commits into from
Jul 27, 2015

Commits on Jul 24, 2015

  1. Fix taxons page with new Spree.ajax calls 

    This was missing a necessary {"X-Spree-Token": Spree.api_key }, which
was causing the API call to error. Also cleaned up the rest of the ajax
calls in the file.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    e87c413 View commit details
    Browse the repository at this point in the history

  2. Just use HTTP methods instead of _method

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    ef8e568 View commit details
    Browse the repository at this point in the history

  3. Fix rollback on js errors in taxonomy.js

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    770671a View commit details
    Browse the repository at this point in the history

  4. Use native browser confirm instead of jquery.alert

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    8887148 View commit details
    Browse the repository at this point in the history

  5. Remove jquery.alerts 

    This was no longer being used.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    fb8f68f View commit details
    Browse the repository at this point in the history

  6. Set base_url in the iffe instead of on window

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    a86ced6 View commit details
    Browse the repository at this point in the history

  7. Simplify taxonomy.js error handling

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    5342022 View commit details
    Browse the repository at this point in the history

  8. Remove dblclick event handler on taxon tree 

    This wasn't working for me in either chrome or firefox, and is
unnecessary as rename is available in the right click menu.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    53d4a84 View commit details
    Browse the repository at this point in the history

  9. Remove hack preventing enter from working 

    There's no reason for this, renaming works fine without it.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    ae04696 View commit details
    Browse the repository at this point in the history

  10. Remove extra spinner from taxonomies/edit 

    There's already a standard spinner, with the same id as this one. I
don't think it was being displayed.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    68401b6 View commit details
    Browse the repository at this point in the history

  11. Separate taxonomy edit buttons from taxon tree 

    The update button on this page is only used for updating the name of the
taxonomy, having it under the tree suggests that it would be used for
updating the tree's structure as well.
    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    fbf58e8 View commit details
    Browse the repository at this point in the history

  12. Add feature spec for taxon tree JS

    @jhawthorn
    jhawthorn committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    1a67709 View commit details
    Browse the repository at this point in the history