Replace deprecated bourbon mixins with unprefixed CSS #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bourbon is removed these mixins from bourbon 5.0 and recommend autoprefixer as a replacement. Fortunately, we have no need to use prefixes since our admin only supports modern browsers (IE11+)
Bourbon is removed these mixins from bourbon 5.0 and recommend autoprefixer as a replacement. Fortunately, we have no need to use prefixes since our admin only supports modern browsers (IE11+)
Bourbon is removed these mixins from bourbon 5.0 and recommend autoprefixer as a replacement. Fortunately, we have no need to use prefixes since our admin only supports modern browsers (IE11+)
Bourbon is removed these mixins from bourbon 5.0 and recommend autoprefixer as a replacement. Fortunately, we have no need to use prefixes since our admin only supports modern browsers (IE11+)
jhawthorn
force-pushed
the
remove_bourbon_css_prefixes
branch
from
cc67d64
to
08c86da
Compare
tvdeyen
approved these changes
Feb 7, 2017
DanielWright
pushed a commit
to glossier/solidus
that referenced
this pull request
Sep 27, 2017
Bourbon deprecated a variety of mixins in 4.3, and recommended using autoprefixer as a replacement. Use of the mixins in the canonical fork of Solidus was resolved in solidusio#1706, and this commit applies the same patch to the Glossier fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bourbon has deprecated a swath of their mixins, planning to remove them in the upcoming 5.0.0. These mixins were for vendor prefixing, for which they now recommend using autoprefixer.
In the admin we only intend to support modern browsers, so we don't need prefixes here at all.