Display Backend only rates in the backend #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the commit, shipping methods that had `display_on` set to `back_end` or `available_to_users`set to `false` would not be displayed in the backend. This commit changes `Spree::Order#refresh_shipment_rates` and `Spree::Shipment#refresh_rates` to accept an optional argument `frontend_only`. If that is set to `false`, the estimator will also take into account backend only rates. Also, the places where `@order.refresh_shipment_rates` are called in the backend now pass `frontend_only: false` to those methods.
mamhoff
force-pushed
the
display-backend-rates-in-backend-on-1.4
branch
from
c0ec503
to
e084404
Compare
|
I'm waiting for the discussion on #1739. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the commit, shipping methods that had
display_onset toback_endoravailable_to_usersset tofalsewould not be displayedin the backend. This commit changes
Spree::Order#refresh_shipment_ratesand
Spree::Shipment#refresh_ratesto accept an optional argumentfrontend_only. If that is set tofalse, the estimator will alsotake into account backend only rates.
Also, the places where
@order.refresh_shipment_ratesare calledin the backend now pass
frontend_only: falseto those methods.This is the same as #1739, but for Solidus 1.4.