Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to nonexistent API attributes #2153

Merged
merged 4 commits into from
Aug 15, 2017

Conversation

jhawthorn
Copy link
Contributor

@jhawthorn jhawthorn commented Aug 14, 2017

RABL silently ignores attributes which don't exist. Whoops!

This makes the following changes to attributes:

  • Remove return_authorization_id from inventory_unit
  • Add finalized adjustment (replacing now nonexistent locked)
  • Remove lock_version from inventory_unit and stock_item
  • Add country_iso to address (which should exist since country_iso= does)

(extracted from #2147)

@jhawthorn jhawthorn merged commit 850ae43 into solidusio:master Aug 15, 2017
@jhawthorn jhawthorn deleted the api_attributes_fixes branch August 15, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants