Improve translation missing strings visual #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text color under a red background makes that text unreadable. Using our red color as text will improve readability. Also, a white background has been added if, for some reason, text is rendered over an element with red background, eg. flash errors.
Backend javascript needs to be loaded before defining inline configurations for specific envs since both Spree.ready and bootstrap tooltips are loaded there.
jhawthorn
approved these changes
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text without translation is currently rendered with current element text color on a red background. This makes that text unreadable:
Using our red color (#C60F13) as text color will improve readability. Also, a white background has been added if, for some reason, text is rendered over an element with red background, eg. flash errors.
At almost no cost, I also added tooltips for those elements since they use element title as tooltip content: