Improve master variant documentation #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Jan 23, 2018
| `Spree::Price`. | ||
| - If a product has more than one variant configured, then the master variant | ||
| does *not* provide the price and other properties to the line item. **In this | ||
| case, the master variant is not saleable**. Instead, it is used as a template |
There was a problem hiding this comment.
Thanks Martin! 👍
benjaminwil
force-pushed
the
products_and_variants_documentation
branch
from
a008479
to
99b7474
Compare
skukx
approved these changes
Jan 25, 2018
| variant created for a product. When additional variants are created, they | ||
| inherit the properties of the master variant until their unique properties are | ||
| set. | ||
| Every product has a master variant. By default, the master variant is first |
There was a problem hiding this comment.
the master variant is first => the master variant is *the* first
There was a problem hiding this comment.
👍 Thanks. Rebased with this change.
Thanks to gmacdougall for his review.
benjaminwil
force-pushed
the
products_and_variants_documentation
branch
from
99b7474
to
be00001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased some changes to the variants article for my last pull request, but I never ended up pushing those changes to
origin.These are changes that @gmacdougall requested when he reviewed my PR. They much improve the documentation currently in
master.My apologies for the mixup. 👍