Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation for details attribute of LogEntry model #2925

Merged

Conversation

bitberry-dev
Copy link

Hi guys,

Noticed place without i18n and invalid font-awesome icons. Fixed.

@bitberry-dev
Copy link
Author

Also, In solidus_gateway I noticed these partials https://github.com/solidusio/solidus_gateway/tree/master/lib/views/backend/spree/admin/log_entries

But I did not find support of these partials in solidus. Seems that long time ago there was custom log entry rendering, in history I found this commit spree/spree#5475

What you think about returning back this feature?

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure about the custom payment methods log entries, can you retrieve some original code to understand the complexity of that part?

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes you have in this PR! Thanks!

Not sure about the follow-up change you mentioned. Do you mind opening an issue so we can discuss that separately?

@bitberry-dev
Copy link
Author

@jacobherrington Okay, I will open an issue for discuss :)

@kennyadsl kennyadsl merged commit 736efde into solidusio:master Nov 26, 2018
@kennyadsl
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants