Minor updates in promotions overview documentation #3121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanCrg90
changed the title
JuanCrg90
changed the title
kennyadsl
approved these changes
Feb 23, 2019
| @@ -140,7 +138,7 @@ See the `eligible?` method defined in the [Spree::Promotion | |||
| model][spree-promotion]: | |||
|
|
|||
| ```ruby | |||
| # models/spree/promotion.rb : line 123 | |||
| # models/spree/promotion.rb : line 120 | |||
There was a problem hiding this comment.
I'm not sure it's a good idea to keep this line number. It's very hard to maintain and it's super easy to find a method into a file with all editors or browsers. Not sure if it's better to take advantage of this change to remove it or we could remove it also in other places (if any) with another PR. WDYT?
There was a problem hiding this comment.
Updated Thanks for the suggestion 😄
The promotions documentation `def eligible?` method line number is unnecessary this updates the documentation reference removing the line number.
jacobherrington
approved these changes
Feb 24, 2019
|
Re-running build to get ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds some minor updates in the promotions documentation.
eligible?method line numberChecklist: