Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates in promotions overview documentation #3121

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Minor updates in promotions overview documentation #3121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c14ad0b
Add adjustments docs link on promotions overview
JuanCrg90 Feb 22, 2019
763b3dc
remove docs eligible? method line number
JuanCrg90 Feb 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions guides/source/developers/promotions/overview.html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,10 @@ Every time that the promotion adjustment needs to be recalculated, the
`Spree::PromotionRule`s are re-checked to ensure the promotion is still
eligible.

Note that shipments and taxes can also create adjustments. See the adjustments
Note that shipments and taxes can also create adjustments. See the [adjustments][adjustments]
documentation for more information.

<!-- TODO:
Once merged, link to documentation about adjustments.
-->
[adjustments]: ../adjustments/overview.html

## Eligibility

Expand All @@ -140,7 +138,7 @@ See the `eligible?` method defined in the [Spree::Promotion
model][spree-promotion]:

```ruby
# models/spree/promotion.rb : line 123
# models/spree/promotion.rb
def eligible?(promotable, promotion_code: nil)
return false if inactive?
return false if usage_limit_exceeded?
Expand Down