Add basic tooling for JS linting #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 9, 2019
houndci-bot
reviewed
Apr 9, 2019
houndci-bot
reviewed
Apr 9, 2019
houndci-bot
reviewed
Apr 9, 2019
aitbw
force-pushed
the
aitbw/js-linting
branch
2 times, most recently
from
e61d599
to
7d30172
Compare
|
But I think it should not close #2849, since it also expects other PR to re-introduce disabled rules. |
|
Correct, @kennyadsl —let me edit the description to avoid automatic closure of that issue. |
tvdeyen
reviewed
May 12, 2019
|
Added a new commit to comply with your suggestions, @tvdeyen 🙌 let me know what you think! |
jacobherrington
approved these changes
May 20, 2019
There was a problem hiding this comment.
I like this, we should merge it pending @tvdeyen's approval.
Several files under `backend/` were raising ESLint errors when linted via `yarn lint`; this commit introduces the aforementioned change to supress these errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2849 for further discussion prior to this PR
This PR aims to add basic tooling for JS linting based on @airbnb's JavaScript Style Guide by doing the following:
Adds a
package.jsonfile with the bare minimum to work as expected —including a Yarn task to automatically check if the rules for all JS files on Solidus (minus those underguides,sandbox,node_modulesandvendor) are being followed. The dependencies for this to work are based on this NPM package, which doesn't include linting specific to JS frameworks, such as ReactIgnores unnecessary newly-introduced files and folders (I'm looking at you,
node_modules👀)Adds ESLint config file with all the warnings/errors raised when running
yarn lintdisabledAdds ESLint inline config comments on several files under
backend, asyarn lintwas complaining even with the config fileEnable JS linting for Hound based on the newly-introduced
.eslintrc.jsonfileWhitelist Solidus-specific global variables
This should allow for other future PRs to re-enable rules and fix its related issues.
Let me know what you think! 🙌
Checklist: