Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence log messages from the capybara server #3484

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jan 23, 2020

Description

Puma is taken as the default rack server, but until rspec/rspec-rails#1897 is solved we should stick to the proposed workaround.

The typical output goes like this:

$ cd frontend; bundle exec rspec ; cd -

Randomized with seed 63849
..........Capybara starting Puma...
* Version 4.3.1 , codename: Mysterious Traveller
* Min threads: 0, max threads: 4
* Listening on tcp://127.0.0.1:59724
.................................................................................................................................................................................................................

Finished in 1 minute 33.28 seconds (files took 5.71 seconds to load)
219 examples, 0 failures

Randomized with seed 63849

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Puma is taken as the default rack server, but until
rspec/rspec-rails#1897 is solved we should
stick to the proposed workaround.
@elia elia marked this pull request as ready for review January 23, 2020 15:32
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thank you 👍

Copy link
Contributor

@DanielePalombo DanielePalombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elia!

@kennyadsl kennyadsl merged commit 27a5055 into solidusio:master Jan 28, 2020
@kennyadsl kennyadsl deleted the elia/silence-capybara-puma-logs branch January 28, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants