Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add bang method when finding product property #3528

Merged
merged 1 commit into from Mar 6, 2020
Merged

[API] Add bang method when finding product property #3528

merged 1 commit into from Mar 6, 2020

Commits on Feb 25, 2020

  1. Add bang method when finding product property 

    If the controller does not find the product property it cannot return an invalid
resource response for that record and then it breaks with 500.
This commit adds the bang method so that the controller can rely on the base
controller rescue_from ActiveRecord::RecordNotFound
https://github.com/solidusio/solidus/blob/v2.10.0/api/app/controllers/spree/api/base_controller.rb#L28
to return a proper message.
    @SamuelMartini
    SamuelMartini committed Feb 25, 2020
    Copy the full SHA
    4b66f49 View commit details
    Browse the repository at this point in the history