Allow Importer::Order to accept array of line items and stock_location_id #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 5, 2020
| shipment.stock_location = Spree::StockLocation.find_by(admin_name: target[:stock_location]) || Spree::StockLocation.find_by!(name: target[:stock_location]) | ||
| shipment.stock_location = Spree::StockLocation.find_by(id: target[:stock_location_id]) || | ||
| Spree::StockLocation.find_by(admin_name: target[:stock_location]) || | ||
| Spree::StockLocation.find_by!(name: target[:stock_location]) |
There was a problem hiding this comment.
Layout/MultilineOperationIndentation: Align the operands of an expression in an assignment spanning multiple lines.
| @@ -56,7 +56,9 @@ def self.create_shipments_from_params(shipments_hash, order) | |||
| shipments_hash.each do |target| | |||
| shipment = Shipment.new | |||
| shipment.tracking = target[:tracking] | |||
| shipment.stock_location = Spree::StockLocation.find_by(admin_name: target[:stock_location]) || Spree::StockLocation.find_by!(name: target[:stock_location]) | |||
| shipment.stock_location = Spree::StockLocation.find_by(id: target[:stock_location_id]) || | |||
| Spree::StockLocation.find_by(admin_name: target[:stock_location]) || | |||
There was a problem hiding this comment.
Layout/MultilineOperationIndentation: Align the operands of an expression in an assignment spanning multiple lines.
kennyadsl
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Thanks @ccarruitero, it works for me.
I'd also deprecate the line_items_hash since it's no more always a hash, maybe line_itemswith some good YARD documentation of this method args is enough to make it more clear. But we can do this in another PR if we have time.
kennyadsl
changed the title
kennyadsl
added
Needs Core Team Review
changelog:solidus_core
aldesantis
reviewed
Jun 23, 2020
aldesantis
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for improve
Importer::Orderto allowstock_location_idwhen create shipments and allow use an array forline_item_attributes.Importer::Orderis used internally forsolidus_apito create orders, and like is documented should allowstock_location_idinshipments_attributesand an array forline_item_attributes.Checklist: