Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup the CI #3699

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Speedup the CI #3699

merged 6 commits into from
Jul 15, 2020

Conversation

elia
Copy link
Member

@elia elia commented Jul 10, 2020

Description

The ci is taking longer and longer, with peaks of 6min just for restoring and saving the bundler's cache

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

elia added 2 commits July 10, 2020 16:42
@elia
Lock and try to restore the exact bundle
9748108 
If the lock matches we can save the installation time entirely.
@elia
Clean the bundle after the installation
843bba5 
This will keep the cached bundle lean and swift.
@elia elia force-pushed the elia/speedup-the-ci branch 3 times, most recently from 13a3003 to 6772329 Compare July 10, 2020 22:14
@elia
Copy link
Member Author

elia commented Jul 10, 2020 •
edited
Loading

It's working! 😄

image

image

@elia elia marked this pull request as ready for review July 13, 2020 15:04
kennyadsl
kennyadsl approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elia! 🚤

jarednorman
jarednorman requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems sensible. There's a typo ("brach" instead of "branch") in one of the commit messages though if you wouldn't mind fixing that.

elia added 2 commits July 13, 2020 18:01
@elia
Keep master as the fallback branch for the bundle
b602ca8
@elia
Bump the bundle CI cache version
f822f54 
Invalidate all previous cache, starting from scratch will be faster
than waiting for all caches to be replaced, which BTW doesn't happen
if a key is already present.
@elia
Copy link
Member Author

elia commented Jul 13, 2020

@jarednorman I don't mind! 🙂 Thanks for pointing that out 👍

@elia elia requested a review from jarednorman July 13, 2020 16:04
@kennyadsl kennyadsl merged commit cca23fc into solidusio:master Jul 15, 2020
@kennyadsl kennyadsl deleted the elia/speedup-the-ci branch July 15, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@jarednorman jarednorman jarednorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @kennyadsl @jarednorman