Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhardcode admin base url in 'stock_location_stock_item' template #4063

Merged
merged 1 commit into from
May 21, 2021

Conversation

ok32
Copy link

@ok32 ok32 commented May 16, 2021

If Solidus is not mounted at '/', the stock movements link on the product stock tab is broken.

image

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

@ok32 ok32 force-pushed the fix/hardcoded-admin-url branch from 5edbab7 to 5bb8529 Compare May 16, 2021 21:58
@ok32 ok32 force-pushed the fix/hardcoded-admin-url branch from 5bb8529 to b324f84 Compare May 16, 2021 22:09
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally. Thanks!

@kennyadsl kennyadsl merged commit 79e6748 into solidusio:master May 21, 2021
@kennyadsl kennyadsl added the changelog:solidus_backend Changes to the solidus_backend gem label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants