Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Deprecate callback setting variant price from master" #4132

Merged
merged 1 commit into from Jul 15, 2021
Merged

Revert "Deprecate callback setting variant price from master" #4132

merged 1 commit into from Jul 15, 2021

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Jul 14, 2021 •
edited

Reverts #4078

For now, we've decided to put the greater goal behind this change
(inheriting all prices from master when creating variants) on hold. The
reason for that is that we have higher priorities and that we'll revisit
refactoring core logic when we implement more events or services on
Solidus.

As the reverted commit raised a deprecation warning, it's better to wait until
we have a clearer direction in mind.

@waiting-for-dev
Revert "Deprecate callback setting variant price from master"
1f4749f 
For now, we've decided to put the greater goal behind this change
(inheriting all prices from master when creating variants) on hold. The
reason for that is that we have higher priorities and that we'll revisit
refactoring core logic when we implement more events or services on
Solidus.

As the reverted commit raised a deprecation warning, it's better to wait
until we have a clearer direction in mind.
@kennyadsl kennyadsl merged commit 0957c0f into solidusio:master Jul 15, 2021
@kennyadsl kennyadsl deleted the waiting_for_dev/revert_deprecate_callback_setting_variant_price_from_master branch July 15, 2021 09:41
@waiting-for-dev waiting-for-dev mentioned this pull request Aug 9, 2021
Merged
5 tasks
waiting-for-dev added a commit to nebulab/solidus that referenced this pull request Sep 10, 2021
@waiting-for-dev
Prepare CHANGELOG for Solidus 3.1 release
a3703cf 
The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))
kennyadsl pushed a commit that referenced this pull request Sep 10, 2021
@waiting-for-dev
Prepare CHANGELOG for Solidus 3.1 release (#4144)
c6f1d92 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [#4140](#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [#4132](#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [#4078](#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [#4100](#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [#4119](#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [#4033](#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
rmparr pushed a commit to rmparr/solidus that referenced this pull request Jun 1, 2022
@waiting-for-dev @rmparr
Prepare CHANGELOG for Solidus 3.1 release (solidusio#4144)
e2d094c 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
rmparr pushed a commit to rmparr/solidus that referenced this pull request Jun 1, 2022
@waiting-for-dev @rmparr
Prepare CHANGELOG for Solidus 3.1 release (solidusio#4144)
9476b07 
* Prepare CHANGELOG for Solidus 3.1 release

The new entries have been generated through the following command, as
detailed in the [how-to-release
guides](https://github.com/solidusio/solidus/wiki/How-to-release-Solidus#make-sure-changelogmd-is-up-to-date):

```bash
git rev-list v3.0.1...master | github_fast_changelog solidusio/solidus
```

The following items have been removed because of being change/revert
pairs or being changes on top of still-unreleased stuff:

- Docker: Change public keys server after deprecation
  [solidusio#4140](solidusio#4140)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Revert "Deprecate callback setting variant price from master"
  [solidusio#4132](solidusio#4132)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Deprecate callback setting variant price from master
  [solidusio#4078](solidusio#4078)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Remove staled comment
  [solidusio#4100](solidusio#4100)
  ([waiting-for-dev](https://github.com/waiting-for-dev))
- Disable perform_caching in DummyApp
  [solidusio#4119](solidusio#4119)
  ([gsmendoza](https://github.com/gsmendoza))
- Master now tracks 3.1.0
  [solidusio#4033](solidusio#4033)
  ([kennyadsl](https://github.com/kennyadsl))

* Add backported entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode spaghetticode approved these changes

@jarednorman jarednorman jarednorman approved these changes

@gmacdougall gmacdougall gmacdougall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@waiting-for-dev @spaghetticode @jarednorman @gmacdougall @kennyadsl