Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change application-template generation script to use main branch #4163

Conversation

kennyadsl
Copy link
Member

Description

To have a Heroku deploy button ready to preview Solidus, we created a repository (updated every time we release a new Minor/Major version) that has the current Solidus code here: https://github.com/solidusio/solidus-example-app.

To generate this app we can launch these commands:

export UPDATE_EXAMPLE_APP_REPO=true # Enable the automatic push to GitHub.​
# Start the generator script that will generate the app 
# inside ./solidus-example-app and push it to GitHub.
solidus/bin/rails-application-template

And this is currently failing because the new application will be created with the default branch named main instead of master now. We need to reflect this change in the command that tries to push the updated app to GitHub.

It is also required to change the main branch in the repository as well.

The new application will be created with the default branch named
main instead of master now and we need to reflect this change in
the command that tries to push the updated app to GitHub. It is
also required to change the main branch in the repository as well.
@kennyadsl kennyadsl self-assigned this Sep 10, 2021
@kennyadsl kennyadsl merged commit 5734001 into solidusio:master Sep 24, 2021
@kennyadsl kennyadsl deleted the kennyadsl/change-appliaction-example-default-branch branch September 24, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants