Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discarded duplicated products bug #4189

Merged
merged 1 commit into from Jun 8, 2022

Commits on Oct 5, 2021

  1. Fix discarded duplicated products bug

    When a product is cloned and then discarded without changing the cloned
    variants SKU, if the product is ever cloned again then the cloning
    process will fail with a variant and master variant SKU validation
    error. This issue occurs because products and their variants are soft
    deleted and therefore the copied SKU will not be unique during the
    second cloning.
    
    The previous variant SKU uniqueness scope did not work for this specific
    case so this conditional was added on top of it.
    
    This commit also includes a validation spec for the variant SKU and a
    spec to catch the deleted duplication error.
    Azeem838 committed Oct 5, 2021
    Copy the full SHA
    5f248b2 View commit details
    Browse the repository at this point in the history